Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move some of the service code generation to compiler api #364

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jordanshatford
Copy link
Collaborator

Part 1 of moving services to compiler api: #273

@jordanshatford jordanshatford requested a review from mrlubos April 12, 2024 06:16
Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: 0aa567c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview Apr 12, 2024 6:16am

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 10.86957% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 84.01%. Comparing base (974dd72) to head (0aa567c).

Files Patch % Lines
packages/openapi-ts/src/utils/handlebars.ts 10.86% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   84.15%   84.01%   -0.14%     
==========================================
  Files          73       73              
  Lines        4809     4799      -10     
  Branches      547      547              
==========================================
- Hits         4047     4032      -15     
- Misses        761      766       +5     
  Partials        1        1              
Flag Coverage Δ
unittests 84.01% <10.86%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit 12b7bf8 into main Apr 12, 2024
14 of 16 checks passed
@jordanshatford jordanshatford deleted the feat/services-to-compiler-api branch April 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants