-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inconsistent indentation in models file when not using format: true
#349
fix: inconsistent indentation in models file when not using format: true
#349
Conversation
🦋 Changeset detectedLatest commit: 24c8169 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
68c2a8b
to
8f9bd6f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 83.42% 84.50% +1.07%
==========================================
Files 74 74
Lines 4815 4776 -39
Branches 551 551
==========================================
+ Hits 4017 4036 +19
+ Misses 797 739 -58
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
isNullable: false, | ||
isReadOnly: false, | ||
...emptyModel, | ||
...base, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my bad. Base is Model
. Ive updated to spread base and removed no longer needed fields so the toType can handle all generation of code
closes: #321
And the added benefit of additional spec comments making it through.