Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run prettier check with lint #346

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: run prettier check with lint #346

merged 1 commit into from
Apr 11, 2024

Conversation

jordanshatford
Copy link
Collaborator

@jordanshatford jordanshatford commented Apr 11, 2024

Run prettier --check when linting to ensure CI catches any formatting issues

@jordanshatford jordanshatford requested a review from mrlubos April 11, 2024 04:42
Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: a34a7a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 4:43am

@jordanshatford jordanshatford changed the title fix: run linting on ci fix: run prettier check with lint Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.54%. Comparing base (deeb38f) to head (a34a7a2).

Files Patch % Lines
packages/openapi-ts/src/utils/write/type.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files          74       74           
  Lines        4806     4806           
  Branches      550      550           
=======================================
  Hits         4015     4015           
  Misses        790      790           
  Partials        1        1           
Flag Coverage Δ
unittests 83.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit fdef540 into main Apr 11, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the fix/ci-run-lint branch April 11, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants