Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): do not ignore additionalProperties when object with properties #323

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 9, 2024

Fixes #322

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 8:26pm

@mrlubos mrlubos marked this pull request as ready for review April 9, 2024 20:25
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 85.71%. Comparing base (22fc6f7) to head (e3df255).

Files Patch % Lines
packages/openapi-ts/src/utils/write/type.ts 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   85.82%   85.71%   -0.12%     
==========================================
  Files          72       72              
  Lines        4621     4626       +5     
  Branches      542      542              
==========================================
- Hits         3966     3965       -1     
- Misses        654      660       +6     
  Partials        1        1              
Flag Coverage Δ
unittests 85.71% <40.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 987076b into main Apr 9, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/model-additional-properties branch April 9, 2024 20:36
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

additionalProperties ignored if properties is defined
1 participant