Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): use compiler api to generate service imports #278

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

jordanshatford
Copy link
Collaborator

  • Add ability to import and export using alias.
  • Add toString to TypeScriptFile class (This should be used instead of tsNodeToString everywhere outside of compiler code)
  • Update services import to use compiler api

@jordanshatford jordanshatford requested a review from mrlubos April 6, 2024 04:57
Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview Apr 6, 2024 4:57am

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 64.51613% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 84.71%. Comparing base (c4b345b) to head (4e2ff2b).

Files Patch % Lines
packages/openapi-ts/src/utils/write/services.ts 26.66% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   84.74%   84.71%   -0.03%     
==========================================
  Files          69       69              
  Lines        4582     4594      +12     
  Branches      509      513       +4     
==========================================
+ Hits         3883     3892       +9     
- Misses        698      701       +3     
  Partials        1        1              
Flag Coverage Δ
unittests 84.71% <64.51%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit 714ef9e into main Apr 6, 2024
14 of 16 checks passed
@jordanshatford jordanshatford deleted the chore/use-compiler-api-for-service-imports branch April 6, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants