Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): use flat config #268

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix(eslint): use flat config #268

merged 4 commits into from
Apr 10, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 5, 2024

Closes #51

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 0:45am

@mrlubos
Copy link
Member Author

mrlubos commented Apr 5, 2024

This isn't ready yet, eslintignore doesn't work and neither does the integration with VS Code. Running lint command still produces errors that aren't highlighted anywhere else.

@jordanshatford jordanshatford force-pushed the fix/eslint-flat-config branch from 167c50e to 92ec675 Compare April 8, 2024 23:27
@jordanshatford jordanshatford marked this pull request as ready for review April 8, 2024 23:29
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (ba2df03) to head (aff89c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files          73       73           
  Lines        4602     4603    +1     
  Branches      544      544           
=======================================
+ Hits         3932     3933    +1     
  Misses        669      669           
  Partials        1        1           
Flag Coverage Δ
unittests 85.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford force-pushed the fix/eslint-flat-config branch from 2b2f069 to 6cb8354 Compare April 10, 2024 00:02
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: aff89c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrlubos mrlubos merged commit 8305346 into main Apr 10, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/eslint-flat-config branch April 10, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade ESLint to new configuration file
2 participants