Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enum): append index number on duplicate name #217

Closed
wants to merge 1 commit into from

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 3, 2024

Fixes #213

@mrlubos mrlubos requested a review from jordanshatford April 3, 2024 00:14
@mrlubos mrlubos marked this pull request as ready for review April 3, 2024 00:14
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 80.88235% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 90.18%. Comparing base (3f195af) to head (6132cf4).

Files Patch % Lines
src/utils/enum.ts 20.00% 12 Missing ⚠️
src/utils/handlebars.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   90.40%   90.18%   -0.22%     
==========================================
  Files          65       65              
  Lines        4003     4026      +23     
  Branches      465      465              
==========================================
+ Hits         3619     3631      +12     
- Misses        383      394      +11     
  Partials        1        1              
Flag Coverage Δ
unittests 90.18% <80.88%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos closed this Apr 3, 2024
@mrlubos mrlubos deleted the fix/enum-duplicate-export branch April 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.31.0 causes multiple exported plain JS enum objects to conflict because of the single models file
2 participants