Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): generate all services in single services.ts file #215

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #214

@jordanshatford jordanshatford requested a review from mrlubos April 2, 2024 22:52
import { SimpleService } from './services/SimpleService';
import { TypesService } from './services/TypesService';
import { UploadService } from './services/UploadService';
import { CollectionFormatService } from './services';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: in separate PR I will be updating to import all of these services in one import (rather than separate import statement for each.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 90.40%. Comparing base (8f3a256) to head (184bdeb).

Files Patch % Lines
src/utils/write/services.ts 54.90% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   90.78%   90.40%   -0.38%     
==========================================
  Files          65       65              
  Lines        3972     4003      +31     
  Branches      461      465       +4     
==========================================
+ Hits         3606     3619      +13     
- Misses        365      383      +18     
  Partials        1        1              
Flag Coverage Δ
unittests 90.40% <55.76%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit 3f195af into main Apr 2, 2024
12 of 14 checks passed
@jordanshatford jordanshatford deleted the feat/all-services-in-one-file branch April 2, 2024 23:16
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate a single file export for services
2 participants