Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): use FormData from node-fetch in node client #173

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

jordanshatford
Copy link
Collaborator

@jordanshatford jordanshatford commented Mar 29, 2024

see comment: #29 (comment)

NOTE: this will fix the issue for the node client, axios will still have bug when appending blob

The node-fetch library provides FormData directly, and it is much more in line with the built in FormData (stabilizing in node 21)

@jordanshatford jordanshatford requested a review from mrlubos March 29, 2024 01:59
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (8994781) to head (2f8e730).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          66       66           
  Lines        3951     3951           
  Branches      476      476           
=======================================
  Hits         3630     3630           
  Misses        320      320           
  Partials        1        1           
Flag Coverage Δ
unittests 91.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit f2ae684 into main Mar 29, 2024
14 checks passed
@jordanshatford jordanshatford deleted the feat/use-node-fetch-form-data branch March 29, 2024 04:04
@github-actions github-actions bot mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants