Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various angular client fixes #167

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

jordanshatford
Copy link
Collaborator

@jordanshatford jordanshatford commented Mar 27, 2024

  • Fix async response interceptors for angular
  • Fix angular client provides
  • Fix deprecations in angular client
  • Add angular snapshots
  • Do not create/export CancelablePromise when using Angular

@jordanshatford jordanshatford requested a review from mrlubos March 27, 2024 22:52
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (dc33ccb) to head (1a5892a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   91.91%   91.92%           
=======================================
  Files          66       66           
  Lines        3947     3949    +2     
  Branches      476      476           
=======================================
+ Hits         3628     3630    +2     
  Misses        318      318           
  Partials        1        1           
Flag Coverage Δ
unittests 91.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford force-pushed the fix/various-angular-client-fixes branch from 947dc08 to 3fc70da Compare March 28, 2024 01:15
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When removing stuff like the cancelable promise, what's that based on? Why was it removed?

@jordanshatford
Copy link
Collaborator Author

When removing stuff like the cancelable promise, what's that based on? Why was it removed?

It's not actually used in the angular client. It returns Observables instead

@jordanshatford
Copy link
Collaborator Author

@mrlubos is this ok to be merged?

@jordanshatford jordanshatford merged commit 7e896e9 into main Mar 28, 2024
14 checks passed
@jordanshatford jordanshatford deleted the fix/various-angular-client-fixes branch March 28, 2024 22:43
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants