-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various angular client fixes #167
Conversation
jordanshatford
commented
Mar 27, 2024
•
edited
Loading
edited
- Fix async response interceptors for angular
- Fix angular client provides
- Fix deprecations in angular client
- Add angular snapshots
- Do not create/export CancelablePromise when using Angular
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 91.91% 91.92%
=======================================
Files 66 66
Lines 3947 3949 +2
Branches 476 476
=======================================
+ Hits 3628 3630 +2
Misses 318 318
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
947dc08
to
3fc70da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When removing stuff like the cancelable promise, what's that based on? Why was it removed?
It's not actually used in the angular client. It returns Observables instead |
@mrlubos is this ok to be merged? |