Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split tanstack query plugin into modules #1513

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 26, 2024

No description provided.

Copy link

stackblitz bot commented Dec 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: a6523a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 10:54pm

@mrlubos mrlubos marked this pull request as ready for review December 26, 2024 22:52
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 7.53731% with 1239 lines in your changes missing coverage. Please review.

Project coverage is 63.22%. Comparing base (cc505ee) to head (a6523a4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ugins/@tanstack/query-core/infiniteQueryOptions.ts 6.22% 452 Missing ⚠️
...pi-ts/src/plugins/@tanstack/query-core/queryKey.ts 6.12% 337 Missing ⚠️
...s/src/plugins/@tanstack/query-core/queryOptions.ts 9.78% 166 Missing ⚠️
...rc/plugins/@tanstack/query-core/mutationOptions.ts 7.58% 134 Missing ⚠️
...api-ts/src/plugins/@tanstack/query-core/useType.ts 10.09% 98 Missing ⚠️
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 9.25% 49 Missing ⚠️
...napi-ts/src/plugins/@tanstack/query-core/client.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   63.39%   63.22%   -0.17%     
==========================================
  Files         143      149       +6     
  Lines       22596    22700     +104     
  Branches     1860     1860              
==========================================
+ Hits        14324    14353      +29     
- Misses       8266     8341      +75     
  Partials        6        6              
Flag Coverage Δ
unittests 63.22% <7.53%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Dec 26, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@hey-api/client-axios@1513
npm i https://pkg.pr.new/@hey-api/openapi-ts@1513
npm i https://pkg.pr.new/@hey-api/client-fetch@1513

commit: a6523a4

@mrlubos mrlubos merged commit 78e68db into main Dec 26, 2024
15 of 17 checks passed
@mrlubos mrlubos deleted the refactor/plugin-tanstack-query branch December 26, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant