Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dynamic require in child_process #1086

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 25, 2024

Closes #1079

Copy link

stackblitz bot commented Sep 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: 0bc1ebe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 9:59am

Copy link

pkg-pr-new bot commented Sep 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1086
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1086
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1086

commit: 0bc1ebe

@mrlubos mrlubos merged commit b53de31 into main Sep 25, 2024
17 checks passed
@mrlubos mrlubos deleted the fix/esm-dynamic-require branch September 25, 2024 10:05
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (4f59e68) to head (0bc1ebe).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
+ Coverage   81.66%   81.79%   +0.13%     
==========================================
  Files         102      102              
  Lines       11445    11421      -24     
  Branches     1231     1231              
==========================================
- Hits         9346     9342       -4     
+ Misses       2096     2076      -20     
  Partials        3        3              
Flag Coverage Δ
unittests 81.79% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic require of "child_process" is not supported
1 participant