Merge pull request #266 from hey-api/fix/config-postfix-models-remove

fix(config): remove postfixModels option
hey-api · Apr 5, 2024 · 9235d63 · 9235d63
2 parents 32bb3a6 + 1dd7624
commit 9235d63
Show file tree

Hide file tree

Showing 15 changed files with 5 additions and 28 deletions.
diff --git a/.changeset/dirty-bottles-provide.md b/.changeset/dirty-bottles-provide.md
@@ -0,0 +1,5 @@
+---
+"@hey-api/openapi-ts": minor
+---
+
+fix(config): remove postfixModels option
diff --git a/packages/openapi-ts/bin/index.js b/packages/openapi-ts/bin/index.js
@@ -26,7 +26,6 @@ const params = program
     .option('--lint [value]', 'Process output folder with linter?')
     .option('--name <value>', 'Custom client class name')
     .option('--operationId [value]', 'Use operationd ID?')
-    .option('--postfixModels <value>', 'Model name postfix')
     .option('--postfixServices <value>', 'Service name postfix')
     .option('--request <value>', 'Path to custom request file')
     .option('--serviceResponse [value]', 'Define shape of returned value from service calls')

diff --git a/packages/openapi-ts/src/index.ts b/packages/openapi-ts/src/index.ts
@@ -102,7 +102,6 @@ const getConfig = async (userConfig: UserConfig, dependencies: Dependencies) =>
         lint = false,
         name,
         operationId = true,
-        postfixModels = '',
         postfixServices = 'Service',
         request,
         serviceResponse = 'body',
@@ -127,12 +126,6 @@ const getConfig = async (userConfig: UserConfig, dependencies: Dependencies) =>
         throw new Error('🚫 output must be within the current working directory');
     }
 
-    if (postfixModels) {
-        console.warn(
-            '⚠️ Deprecation warning: postfixModels. This setting will be removed in future versions. Please create an issue wih your use case if you need this option https://github.com/hey-api/openapi-ts/issues'
-        );
-    }
-
     if (postfixServices && postfixServices !== 'Service') {
         console.warn(
             '⚠️ Deprecation warning: postfixServices. This setting will be removed in future versions. Please create an issue wih your use case if you need this option https://github.com/hey-api/openapi-ts/issues'
@@ -164,7 +157,6 @@ const getConfig = async (userConfig: UserConfig, dependencies: Dependencies) =>
         name,
         operationId,
         output,
-        postfixModels,
         postfixServices,
         request,
         serviceResponse,

diff --git a/packages/openapi-ts/src/openApi/__tests__/index.spec.ts b/packages/openapi-ts/src/openApi/__tests__/index.spec.ts
@@ -23,7 +23,6 @@ describe('parse', () => {
         lint: false,
         operationId: true,
         output: '',
-        postfixModels: '',
         postfixServices: '',
         serviceResponse: 'body',
         useDateType: false,

diff --git a/packages/openapi-ts/src/openApi/v2/parser/__tests__/getServices.spec.ts b/packages/openapi-ts/src/openApi/v2/parser/__tests__/getServices.spec.ts
@@ -18,7 +18,6 @@ describe('getServices', () => {
             lint: false,
             operationId: false,
             output: '',
-            postfixModels: '',
             postfixServices: 'Service',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/openApi/v3/parser/__tests__/getServices.spec.ts b/packages/openapi-ts/src/openApi/v3/parser/__tests__/getServices.spec.ts
@@ -18,7 +18,6 @@ describe('getServices', () => {
             lint: false,
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: 'Service',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/types/config.ts b/packages/openapi-ts/src/types/config.ts
@@ -70,11 +70,6 @@ export interface UserConfig {
      * The relative location of the output directory
      */
     output: string;
-    /**
-     * Model name postfix
-     * @default '''
-     */
-    postfixModels?: string;
     /**
      * Service name postfix
      * @default 'Service'

diff --git a/packages/openapi-ts/src/utils/__tests__/handlebars.spec.ts b/packages/openapi-ts/src/utils/__tests__/handlebars.spec.ts
@@ -20,7 +20,6 @@ describe('registerHandlebarHelpers', () => {
                 lint: false,
                 operationId: true,
                 output: '',
-                postfixModels: '',
                 postfixServices: '',
                 serviceResponse: 'body',
                 useDateType: false,
@@ -75,7 +74,6 @@ describe('registerHandlebarTemplates', () => {
                 lint: false,
                 operationId: true,
                 output: '',
-                postfixModels: '',
                 postfixServices: '',
                 serviceResponse: 'body',
                 useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/class.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/class.spec.ts
@@ -32,7 +32,6 @@ describe('writeClientClass', () => {
             name: 'AppClient',
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: '',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/client.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/client.spec.ts
@@ -31,7 +31,6 @@ describe('writeClient', () => {
             lint: false,
             operationId: true,
             output: './dist',
-            postfixModels: 'AppClient',
             postfixServices: 'Service',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/core.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/core.spec.ts
@@ -38,7 +38,6 @@ describe('writeClientCore', () => {
             name: 'AppClient',
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: '',
             serviceResponse: 'body',
             useDateType: false,
@@ -81,7 +80,6 @@ describe('writeClientCore', () => {
             name: 'AppClient',
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: '',
             serviceResponse: 'body',
             useDateType: false,
@@ -124,7 +122,6 @@ describe('writeClientCore', () => {
             name: 'AppClient',
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: '',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/index.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/index.spec.ts
@@ -32,7 +32,6 @@ describe('writeClientIndex', () => {
             lint: false,
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: 'Service',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/models.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/models.spec.ts
@@ -52,7 +52,6 @@ describe('writeClientModels', () => {
             name: 'AppClient',
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: '',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/schemas.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/schemas.spec.ts
@@ -52,7 +52,6 @@ describe('writeClientSchemas', () => {
             name: 'AppClient',
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: '',
             serviceResponse: 'body',
             useDateType: false,

diff --git a/packages/openapi-ts/src/utils/write/__tests__/services.spec.ts b/packages/openapi-ts/src/utils/write/__tests__/services.spec.ts
@@ -38,7 +38,6 @@ describe('writeClientServices', () => {
             lint: false,
             operationId: true,
             output: '',
-            postfixModels: '',
             postfixServices: 'Service',
             serviceResponse: 'body',
             useDateType: false,