chore: address comments on pr

hey-api · Mar 20, 2024 · 76ee795 · 76ee795
1 parent 0bddfba
commit 76ee795
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 71 deletions.
diff --git a/handlebars.ts b/handlebars.ts
diff --git a/rollup.config.ts b/rollup.config.ts
@@ -7,10 +7,63 @@ import json from '@rollup/plugin-json';
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 import terser from '@rollup/plugin-terser';
 import typescript from '@rollup/plugin-typescript';
+import handlebars from 'handlebars';
 import type { RollupOptions } from 'rollup';
-import { defineConfig } from 'rollup';
+import { defineConfig, type Plugin } from 'rollup';
 
-import { handlebarsPlugin } from './handlebars';
+/**
+ * Custom plugin to parse handlebar imports and precompile
+ * the template on the fly. This reduces runtime by about
+ * half on large projects.
+ */
+export function handlebarsPlugin(): Plugin {
+    return {
+        name: 'handlebars',
+        resolveId: (file: any, importer: any) => {
+            if (path.extname(file) === '.hbs') {
+                return path.resolve(path.dirname(importer), file);
+            }
+            return null;
+        },
+        load: (file: any) => {
+            if (path.extname(file) === '.hbs') {
+                const template = readFileSync(file, 'utf8').toString().trim();
+                const templateSpec = handlebars.precompile(template, {
+                    knownHelpers: {
+                        camelCase: true,
+                        dataParameters: true,
+                        debugThis: true,
+                        enumKey: true,
+                        enumName: true,
+                        enumUnionType: true,
+                        enumValue: true,
+                        equals: true,
+                        escapeComment: true,
+                        escapeDescription: true,
+                        escapeNewline: true,
+                        exactArray: true,
+                        ifdef: true,
+                        ifOperationDataOptional: true,
+                        intersection: true,
+                        modelImports: true,
+                        modelsExports: true,
+                        modelUnionType: true,
+                        nameOperationDataType: true,
+                        notEquals: true,
+                        operationDataType: true,
+                        useDateType: true,
+                    },
+                    knownHelpersOnly: true,
+                    noEscape: true,
+                    preventIndent: true,
+                    strict: true,
+                });
+                return `export default ${templateSpec};`;
+            }
+            return null;
+        },
+    };
+}
 
 const __dirname = fileURLToPath(new URL('.', import.meta.url));
 

diff --git a/src/utils/__mocks__/fileSystem.ts b/src/utils/__mocks__/fileSystem.ts
diff --git a/vitest.config.e2e.ts b/vitest.config.e2e.ts
@@ -2,7 +2,7 @@ import { fileURLToPath } from 'node:url';
 
 import { defineConfig } from 'vitest/config';
 
-import { handlebarsPlugin } from './handlebars';
+import { handlebarsPlugin } from './rollup.config';
 
 export default defineConfig({
     plugins: [handlebarsPlugin()],

diff --git a/vitest.config.unit.ts b/vitest.config.unit.ts
@@ -2,7 +2,7 @@ import { fileURLToPath } from 'node:url';
 
 import { configDefaults, defineConfig } from 'vitest/config';
 
-import { handlebarsPlugin } from './handlebars';
+import { handlebarsPlugin } from './rollup.config';
 
 export default defineConfig({
     plugins: [handlebarsPlugin()],