fix(client): various warnings in generated client

hey-api · Mar 27, 2024 · 33028b7 · 33028b7
1 parent 98f9d38
commit 33028b7
Show file tree

Hide file tree

Showing 14 changed files with 33 additions and 34 deletions.
diff --git a/.changeset/weak-wombats-shop.md b/.changeset/weak-wombats-shop.md
@@ -0,0 +1,5 @@
+---
+"@hey-api/openapi-ts": patch
+---
+
+fix various warnings in generated client code
diff --git a/src/templates/core/angular/getHeaders.hbs b/src/templates/core/angular/getHeaders.hbs
@@ -11,7 +11,7 @@ export const getHeaders = (config: OpenAPIConfig, options: ApiRequestOptions): O
 				...additionalHeaders,
 				...options.headers,
 			})
-				.filter(([_, value]) => value !== undefined && value !== null)
+				.filter(([, value]) => value !== undefined && value !== null)
 				.reduce((headers, [key, value]) => ({
 					...headers,
 					[key]: String(value),

diff --git a/src/templates/core/axios/getHeaders.hbs b/src/templates/core/axios/getHeaders.hbs
@@ -14,7 +14,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
 		...options.headers,
 		...formHeaders,
 	})
-	.filter(([_, value]) => value !== undefined && value !== null)
+	.filter(([, value]) => value !== undefined && value !== null)
 	.reduce((headers, [key, value]) => ({
 		...headers,
 		[key]: String(value),

diff --git a/src/templates/core/fetch/getHeaders.hbs b/src/templates/core/fetch/getHeaders.hbs
@@ -11,7 +11,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
 		...additionalHeaders,
 		...options.headers,
 	})
-		.filter(([_, value]) => value !== undefined && value !== null)
+		.filter(([, value]) => value !== undefined && value !== null)
 		.reduce((headers, [key, value]) => ({
 			...headers,
 			[key]: String(value),

diff --git a/src/templates/core/functions/base64.hbs b/src/templates/core/functions/base64.hbs
@@ -2,7 +2,7 @@ export const base64 = (str: string): string => {
 	try {
 		return btoa(str);
 	} catch (err) {
-		// @ts-ignore
+		// @ts-expect-error Buffer may not be found.
 		return Buffer.from(str).toString('base64');
 	}
 };
diff --git a/src/templates/core/functions/getFormData.hbs b/src/templates/core/functions/getFormData.hbs
@@ -2,7 +2,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
 	if (options.formData) {
 		const formData = new FormData();
 
-		const process = (key: string, value: any) => {
+		const process = (key: string, value: unknown) => {
 			if (isString(value) || isBlob(value)) {
 				formData.append(key, value);
 			} else {
@@ -11,7 +11,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
 		};
 
 		Object.entries(options.formData)
-			.filter(([_, value]) => value !== undefined && value !== null)
+			.filter(([, value]) => value !== undefined && value !== null)
 			.forEach(([key, value]) => {
 				if (Array.isArray(value)) {
 					value.forEach(v => process(key, v));

diff --git a/src/templates/core/functions/isBlob.hbs b/src/templates/core/functions/isBlob.hbs
@@ -8,7 +8,6 @@ export const isBlob = (value: any): value is Blob => {
 		typeof value.constructor === 'function' &&
 		typeof value.constructor.name === 'string' &&
 		/^(Blob|File)$/.test(value.constructor.name) &&
-		// @ts-ignore
 		/^(Blob|File)$/.test(value[Symbol.toStringTag])
 	);
 };
diff --git a/src/templates/core/node/getHeaders.hbs b/src/templates/core/node/getHeaders.hbs
@@ -11,7 +11,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
 		...additionalHeaders,
 		...options.headers,
 	})
-		.filter(([_, value]) => value !== undefined && value !== null)
+		.filter(([, value]) => value !== undefined && value !== null)
 		.reduce((headers, [key, value]) => ({
 			...headers,
 			[key]: String(value),

diff --git a/src/templates/core/xhr/getHeaders.hbs b/src/templates/core/xhr/getHeaders.hbs
@@ -11,7 +11,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
 		...additionalHeaders,
 		...options.headers,
 	})
-		.filter(([_, value]) => value !== undefined && value !== null)
+		.filter(([, value]) => value !== undefined && value !== null)
 		.reduce((headers, [key, value]) => ({
 			...headers,
 			[key]: String(value),

diff --git a/test/__snapshots__/v2/test/generated/v2/core/request.ts.snap b/test/__snapshots__/v2/test/generated/v2/core/request.ts.snap
@@ -23,7 +23,6 @@ export const isBlob = (value: any): value is Blob => {
         typeof value.constructor === 'function' &&
         typeof value.constructor.name === 'string' &&
         /^(Blob|File)$/.test(value.constructor.name) &&
-        // @ts-ignore
         /^(Blob|File)$/.test(value[Symbol.toStringTag])
     );
 };
@@ -36,7 +35,7 @@ export const base64 = (str: string): string => {
     try {
         return btoa(str);
     } catch (err) {
-        // @ts-ignore
+        // @ts-expect-error Buffer may not be found.
         return Buffer.from(str).toString('base64');
     }
 };
@@ -87,7 +86,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
     if (options.formData) {
         const formData = new FormData();
 
-        const process = (key: string, value: any) => {
+        const process = (key: string, value: unknown) => {
             if (isString(value) || isBlob(value)) {
                 formData.append(key, value);
             } else {
@@ -96,7 +95,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
         };
 
         Object.entries(options.formData)
-            .filter(([_, value]) => value !== undefined && value !== null)
+            .filter(([, value]) => value !== undefined && value !== null)
             .forEach(([key, value]) => {
                 if (Array.isArray(value)) {
                     value.forEach(v => process(key, v));
@@ -132,7 +131,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
         ...additionalHeaders,
         ...options.headers,
     })
-        .filter(([_, value]) => value !== undefined && value !== null)
+        .filter(([, value]) => value !== undefined && value !== null)
         .reduce(
             (headers, [key, value]) => ({
                 ...headers,

diff --git a/test/__snapshots__/v3-client/test/generated/v3_client/core/request.ts.snap b/test/__snapshots__/v3-client/test/generated/v3_client/core/request.ts.snap
@@ -23,7 +23,6 @@ export const isBlob = (value: any): value is Blob => {
         typeof value.constructor === 'function' &&
         typeof value.constructor.name === 'string' &&
         /^(Blob|File)$/.test(value.constructor.name) &&
-        // @ts-ignore
         /^(Blob|File)$/.test(value[Symbol.toStringTag])
     );
 };
@@ -36,7 +35,7 @@ export const base64 = (str: string): string => {
     try {
         return btoa(str);
     } catch (err) {
-        // @ts-ignore
+        // @ts-expect-error Buffer may not be found.
         return Buffer.from(str).toString('base64');
     }
 };
@@ -87,7 +86,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
     if (options.formData) {
         const formData = new FormData();
 
-        const process = (key: string, value: any) => {
+        const process = (key: string, value: unknown) => {
             if (isString(value) || isBlob(value)) {
                 formData.append(key, value);
             } else {
@@ -96,7 +95,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
         };
 
         Object.entries(options.formData)
-            .filter(([_, value]) => value !== undefined && value !== null)
+            .filter(([, value]) => value !== undefined && value !== null)
             .forEach(([key, value]) => {
                 if (Array.isArray(value)) {
                     value.forEach(v => process(key, v));
@@ -132,7 +131,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
         ...additionalHeaders,
         ...options.headers,
     })
-        .filter(([_, value]) => value !== undefined && value !== null)
+        .filter(([, value]) => value !== undefined && value !== null)
         .reduce(
             (headers, [key, value]) => ({
                 ...headers,

diff --git a/test/__snapshots__/v3-legacy-enums/test/generated/v3_legacy_enums/core/request.ts.snap b/test/__snapshots__/v3-legacy-enums/test/generated/v3_legacy_enums/core/request.ts.snap
@@ -23,7 +23,6 @@ export const isBlob = (value: any): value is Blob => {
         typeof value.constructor === 'function' &&
         typeof value.constructor.name === 'string' &&
         /^(Blob|File)$/.test(value.constructor.name) &&
-        // @ts-ignore
         /^(Blob|File)$/.test(value[Symbol.toStringTag])
     );
 };
@@ -36,7 +35,7 @@ export const base64 = (str: string): string => {
     try {
         return btoa(str);
     } catch (err) {
-        // @ts-ignore
+        // @ts-expect-error Buffer may not be found.
         return Buffer.from(str).toString('base64');
     }
 };
@@ -87,7 +86,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
     if (options.formData) {
         const formData = new FormData();
 
-        const process = (key: string, value: any) => {
+        const process = (key: string, value: unknown) => {
             if (isString(value) || isBlob(value)) {
                 formData.append(key, value);
             } else {
@@ -96,7 +95,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
         };
 
         Object.entries(options.formData)
-            .filter(([_, value]) => value !== undefined && value !== null)
+            .filter(([, value]) => value !== undefined && value !== null)
             .forEach(([key, value]) => {
                 if (Array.isArray(value)) {
                     value.forEach(v => process(key, v));
@@ -132,7 +131,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
         ...additionalHeaders,
         ...options.headers,
     })
-        .filter(([_, value]) => value !== undefined && value !== null)
+        .filter(([, value]) => value !== undefined && value !== null)
         .reduce(
             (headers, [key, value]) => ({
                 ...headers,

diff --git a/test/__snapshots__/v3-options/test/generated/v3_options/core/request.ts.snap b/test/__snapshots__/v3-options/test/generated/v3_options/core/request.ts.snap
@@ -23,7 +23,6 @@ export const isBlob = (value: any): value is Blob => {
         typeof value.constructor === 'function' &&
         typeof value.constructor.name === 'string' &&
         /^(Blob|File)$/.test(value.constructor.name) &&
-        // @ts-ignore
         /^(Blob|File)$/.test(value[Symbol.toStringTag])
     );
 };
@@ -36,7 +35,7 @@ export const base64 = (str: string): string => {
     try {
         return btoa(str);
     } catch (err) {
-        // @ts-ignore
+        // @ts-expect-error Buffer may not be found.
         return Buffer.from(str).toString('base64');
     }
 };
@@ -87,7 +86,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
     if (options.formData) {
         const formData = new FormData();
 
-        const process = (key: string, value: any) => {
+        const process = (key: string, value: unknown) => {
             if (isString(value) || isBlob(value)) {
                 formData.append(key, value);
             } else {
@@ -96,7 +95,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
         };
 
         Object.entries(options.formData)
-            .filter(([_, value]) => value !== undefined && value !== null)
+            .filter(([, value]) => value !== undefined && value !== null)
             .forEach(([key, value]) => {
                 if (Array.isArray(value)) {
                     value.forEach(v => process(key, v));
@@ -132,7 +131,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
         ...additionalHeaders,
         ...options.headers,
     })
-        .filter(([_, value]) => value !== undefined && value !== null)
+        .filter(([, value]) => value !== undefined && value !== null)
         .reduce(
             (headers, [key, value]) => ({
                 ...headers,

diff --git a/test/__snapshots__/v3/test/generated/v3/core/request.ts.snap b/test/__snapshots__/v3/test/generated/v3/core/request.ts.snap
@@ -23,7 +23,6 @@ export const isBlob = (value: any): value is Blob => {
         typeof value.constructor === 'function' &&
         typeof value.constructor.name === 'string' &&
         /^(Blob|File)$/.test(value.constructor.name) &&
-        // @ts-ignore
         /^(Blob|File)$/.test(value[Symbol.toStringTag])
     );
 };
@@ -36,7 +35,7 @@ export const base64 = (str: string): string => {
     try {
         return btoa(str);
     } catch (err) {
-        // @ts-ignore
+        // @ts-expect-error Buffer may not be found.
         return Buffer.from(str).toString('base64');
     }
 };
@@ -87,7 +86,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
     if (options.formData) {
         const formData = new FormData();
 
-        const process = (key: string, value: any) => {
+        const process = (key: string, value: unknown) => {
             if (isString(value) || isBlob(value)) {
                 formData.append(key, value);
             } else {
@@ -96,7 +95,7 @@ export const getFormData = (options: ApiRequestOptions): FormData | undefined =>
         };
 
         Object.entries(options.formData)
-            .filter(([_, value]) => value !== undefined && value !== null)
+            .filter(([, value]) => value !== undefined && value !== null)
             .forEach(([key, value]) => {
                 if (Array.isArray(value)) {
                     value.forEach(v => process(key, v));
@@ -132,7 +131,7 @@ export const getHeaders = async (config: OpenAPIConfig, options: ApiRequestOptio
         ...additionalHeaders,
         ...options.headers,
     })
-        .filter(([_, value]) => value !== undefined && value !== null)
+        .filter(([, value]) => value !== undefined && value !== null)
         .reduce(
             (headers, [key, value]) => ({
                 ...headers,