-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump Node.js version of netlify #2240
Conversation
Signed-off-by: Uiolee <[email protected]>
Theme thumbnails validation completed. |
BTW, is it possible to use a string like |
https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript It looks like we can use any valid string that nvm understands |
https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-environment
Solution: https://typicode.github.io/husky/how-to.html#ci-server-and-docker commit: e7f7b99 |
@uiolee Or maybe we should make the husky skip hook setup in CI. We don't commit anything inside the CI after all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add HUSKY=0
to Netlify as well?
https://typicode.github.io/husky/how-to.html#ci-server-and-docker
adding when setting when using e7f7b99, husky and git hooks will not be initialized. So husky will not be triggered at all. so |
#2238 build failed due to low node version.