Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify dispmanx layer #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nagualcode
Copy link

Set Layer number to argument 2.

Set Layer number to argument 2.
@hex007
Copy link
Owner

hex007 commented May 31, 2019

@nagualcode I would look into the PRs over this weekend. Apologies for all the delay

@@ -20,8 +20,9 @@ static void signalHandler(int signalNumber)
void usage(const char *program)
{
fprintf(stderr, "Usage: %s ", program);
fprintf(stderr, "<file> [x y w h]\n");
fprintf(stderr, "<file> l [x y w h]\n");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [] here denotes optional param so I think the layer should also be denoted as optional > [l] [

fprintf(stderr, " file png or jpeg file to display\n");
fprintf(stderr, " l layer, if not specified, layer will be 1.\n");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dispmanx layer to use; defaults to 1\n"

Also the full stop is not needed

layer = atoi(argv[2]);
break;
case 6:
f_name = argv[1];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent tab

@hex007 hex007 changed the title Update eop.c Add support to specify dispmanx layer Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants