Reduce baseline

Signed-off-by: Côme Chilliet <[email protected]>
hetzneronline · Apr 1, 2022 · 391d6da · 391d6da
1 parent 7563727
commit 391d6da
Show file tree

Hide file tree

Showing 4 changed files with 60 additions and 47 deletions.
diff --git a/composer.json b/composer.json
@@ -3,6 +3,7 @@
 		"nextcloud/coding-standard": "^0.4.0",
 		"christophwurst/nextcloud": "dev-master@dev",
 		"psalm/phar": "^4.22",
+		"bantu/ini-get-wrapper": "v1.0.1",
 		"phpunit/phpunit": "^9.5"
 	},
 	"scripts": {

diff --git a/composer.lock b/composer.lock
diff --git a/lib/OperatingSystems/FreeBSD.php b/lib/OperatingSystems/FreeBSD.php
@@ -26,11 +26,6 @@
 use OCA\ServerInfo\Resources\Disk;
 use OCA\ServerInfo\Resources\Memory;
 
-/**
- * Class FreeBSD
- *
- * @package OCA\ServerInfo\OperatingSystems
- */
 class FreeBSD implements IOperatingSystem {
 
 	public function supported(): bool {
@@ -81,7 +76,7 @@ public function getCpuName(): string {
 			$model = $this->executeCommand('/sbin/sysctl -n hw.model');
 			$cores = $this->executeCommand('/sbin/sysctl -n kern.smp.cpus');
 
-			if ($cores === 1) {
+			if ((int)$cores === 1) {
 				$data = $model . ' (1 core)';
 			} else {
 				$data = $model . ' (' . $cores . ' cores)';

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -28,19 +28,6 @@
       <code>$matches['Used'][$i]</code>
       <code>$matches['Used'][0]</code>
     </InvalidOperand>
-    <TypeDoesNotContainType occurrences="2">
-      <code>$cores === 1</code>
-      <code>$cores === 1</code>
-    </TypeDoesNotContainType>
-  </file>
-  <file src="lib/PhpStatistics.php">
-    <UndefinedClass occurrences="5">
-      <code>$this-&gt;phpIni</code>
-      <code>$this-&gt;phpIni</code>
-      <code>$this-&gt;phpIni</code>
-      <code>IniGetWrapper</code>
-      <code>IniGetWrapper</code>
-    </UndefinedClass>
   </file>
   <file src="lib/SystemStatistics.php">
     <RedundantCondition occurrences="1">
@@ -49,11 +36,8 @@
     <TypeDoesNotContainType occurrences="1">
       <code>$loadavg === false</code>
     </TypeDoesNotContainType>
-    <UndefinedClass occurrences="6">
+    <UndefinedClass occurrences="3">
       <code>$this-&gt;installer</code>
-      <code>$this-&gt;phpIni</code>
-      <code>IniGetWrapper</code>
-      <code>IniGetWrapper</code>
       <code>Installer</code>
       <code>Installer</code>
     </UndefinedClass>