test: update server type list index to ignore cx11 entry #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
===========================================
+ Coverage 34.24% 69.67% +35.42%
===========================================
Files 64 64
Lines 7974 7974
===========================================
+ Hits 2731 5556 +2825
+ Misses 5202 1718 -3484
- Partials 41 700 +659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Could we update the test data to use cx11 instead? And fix it again once we removed it? |
apricote
force-pushed
the
skip-server-type-list-test
branch
from
df007d0 to
7c768ab
Compare
…nges Do not hardcode the list indices of the two server types we verify. Instead get the list from the API and calculate the expected indices. This makes us more resilient against changes to the list when server types are deprecated/removed.
apricote
force-pushed
the
skip-server-type-list-test
branch
from
7c768ab to
78d6f43
Compare
apricote
changed the title
I updated the PR to instead get the indices of |
jooola
reviewed
Sep 12, 2024
jooola
changed the title
jooola
changed the title
|
Let me know what you think |
jooola
approved these changes
Sep 12, 2024
|
Works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not hardcode the list indices of the two server types we verify. Instead get the list from the API and calculate the expected indices.
This makes us more resilient against changes to the list when server types are deprecated/removed.