fix(primary-ip): conflict when deleting IP #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
- Coverage 34.27% 34.24% -0.03%
==========================================
Files 62 64 +2
Lines 7915 7974 +59
==========================================
+ Hits 2713 2731 +18
- Misses 5161 5202 +41
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There sometimes happens a conflict in terraform 1.9+ as it handles the state update before a delete differently. Both the server resource as well as the Primary IP resource try to shut down the server, even though the Primary IP should not as it is no longer assigned to the server. This causes our e2e tests to fail. This fixes the regression by explicitly checking that the server still has the IP assigned before trying to detach it.
apricote
force-pushed
the
primary-ip-detach-workaround
branch
from
5fc0756 to
7f931ff
Compare
jooola
approved these changes
Sep 11, 2024
jooola
pushed a commit
that referenced
this pull request
Nov 7, 2024
🤖 I have created a release *beep* *boop* --- ## [1.49.0](v1.48.1...v1.49.0) (2024-11-07) ### Features * add data.load_balancer_type(s) data sources ([#991](#991)) ([ef60613](ef60613)) * add support for opentofu v1.8 ([#1029](#1029)) ([c7902de](c7902de)) * drop support for opentofu v1.6 ([#1030](#1030)) ([8c448dd](8c448dd)) ### Bug Fixes * do not retry deleting a protected primary ip ([#1015](#1015)) ([e9de286](e9de286)), closes [#1014](#1014) * **primary-ip:** conflict when deleting IP ([#994](#994)) ([0873fb1](0873fb1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There sometimes happens a conflict in terraform 1.9+ as it handles the state update before a delete differently. Both the server resource as well as the Primary IP resource try to shut down the server, even though the Primary IP should not as it is no longer assigned to the server.
This causes our e2e tests to fail.
This fixes the regression by explicitly checking that the server still has the IP assigned before trying to detach it.