Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace datasourceutil.MergeSchema with merge.Maps #990

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Sep 6, 2024

Use an existing generic function instead of a specialized one.

@jooola jooola requested a review from a team as a code owner September 6, 2024 13:50
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.21%. Comparing base (ed5156b) to head (b02c491).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   34.24%   34.21%   -0.04%     
==========================================
  Files          64       63       -1     
  Lines        7972     7968       -4     
==========================================
- Hits         2730     2726       -4     
  Misses       5201     5201              
  Partials       41       41              
Flag Coverage Δ
unit 34.21% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 21cd73e into main Sep 10, 2024
3 of 7 checks passed
@jooola jooola deleted the refactor-merge-maps branch September 10, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants