Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add ListID to datasourceutil package #989

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor: add ListID to datasourceutil package #989

merged 1 commit into from
Sep 10, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Sep 6, 2024

Reuse a function to compute the data source list IDs.

@jooola jooola requested a review from a team as a code owner September 6, 2024 13:47
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 34.28%. Comparing base (ed5156b) to head (fbe8c70).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/certificate/data_source.go 0.00% 1 Missing ⚠️
internal/datacenter/data_source.go 0.00% 1 Missing ⚠️
internal/firewall/data_source.go 0.00% 1 Missing ⚠️
internal/floatingip/data_source.go 0.00% 1 Missing ⚠️
internal/image/data_source.go 0.00% 1 Missing ⚠️
internal/loadbalancer/data_source.go 0.00% 1 Missing ⚠️
internal/location/data_source.go 0.00% 1 Missing ⚠️
internal/network/data_source.go 0.00% 1 Missing ⚠️
internal/placementgroup/data_source.go 0.00% 1 Missing ⚠️
internal/primaryip/data_source.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   34.24%   34.28%   +0.04%     
==========================================
  Files          64       65       +1     
  Lines        7972     7977       +5     
==========================================
+ Hits         2730     2735       +5     
  Misses       5201     5201              
  Partials       41       41              
Flag Coverage Δ
unit 34.28% <27.77%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 7fc11e9 into main Sep 10, 2024
3 of 7 checks passed
@jooola jooola deleted the list-id-util branch September 10, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants