Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move data.hcloud_server_type(s) to Plugin Framework #959

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 23, 2024

Related to #752

@jooola jooola changed the title refactor: move data.hcloud_location(s) to Plugin Framework refactor: move data.hcloud_server_type(s) to Plugin Framework Jul 23, 2024
@jooola
Copy link
Member Author

jooola commented Jul 23, 2024

@jooola jooola force-pushed the plugin-framework-server-type branch from 8885e6b to 4b779ca Compare July 24, 2024 08:11
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 86.28571% with 24 lines in your changes missing coverage. Please review.

Project coverage is 69.62%. Comparing base (d73828a) to head (1839ed7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/servertype/data_source.go 86.12% 17 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
- Coverage   69.65%   69.62%   -0.03%     
==========================================
  Files          64       64              
  Lines        7974     8010      +36     
==========================================
+ Hits         5554     5577      +23     
- Misses       1719     1730      +11     
- Partials      701      703       +2     
Flag Coverage Δ
e2e 69.62% <86.28%> (-0.03%) ⬇️
unit 34.14% <41.71%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola force-pushed the plugin-framework-server-type branch 2 times, most recently from 4f725b7 to fc51216 Compare September 6, 2024 11:36
@jooola
Copy link
Member Author

jooola commented Sep 6, 2024

For the plugin framework upgrade test to work, we must release a patch version with #984.

@jooola jooola marked this pull request as ready for review September 6, 2024 11:37
@jooola jooola requested a review from a team as a code owner September 6, 2024 11:37
@jooola jooola force-pushed the plugin-framework-server-type branch 2 times, most recently from 07e9938 to 79a9d03 Compare September 10, 2024 12:02
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great besides the cx11 issue and the one question I had.

internal/servertype/data_source_test.go Outdated Show resolved Hide resolved
@jooola jooola force-pushed the plugin-framework-server-type branch from 79a9d03 to 1839ed7 Compare September 12, 2024 13:03
@jooola jooola merged commit ac90449 into main Sep 12, 2024
7 checks passed
@jooola jooola deleted the plugin-framework-server-type branch September 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants