Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor acceptance test names #1069

Merged
merged 4 commits into from
Jan 9, 2025
Merged

test: refactor acceptance test names #1069

merged 4 commits into from
Jan 9, 2025

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 9, 2025

This PR renames the acceptance test names to have a consistent schema.
Most importantly, all acceptance tests now start with TestAcc, making them be runnable separately from regular unit tests by specifying a regex in go test.

@phm07 phm07 self-assigned this Jan 9, 2025
@phm07 phm07 requested a review from a team as a code owner January 9, 2025 14:09
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.60%. Comparing base (103bca0) to head (b62dba7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   30.60%   30.60%           
=======================================
  Files          66       66           
  Lines        9942     9942           
=======================================
  Hits         3043     3043           
  Misses       6859     6859           
  Partials       40       40           
Flag Coverage Δ
unit 30.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the data source naming convention.

The _Basic suffix seem unneeded, I added a bunch of examples to illustrate my idea.

@phm07 phm07 requested a review from jooola January 9, 2025 15:49
@jooola jooola force-pushed the refactor-acc-tests branch from 6b91966 to b62dba7 Compare January 9, 2025 16:15
@jooola
Copy link
Member

jooola commented Jan 9, 2025

Added a missing update and rebased onto the main branch.

CI is probably going to fail, feel free to merge anyway, its unrelated.

@phm07 phm07 merged commit ff735d3 into main Jan 9, 2025
4 of 7 checks passed
@phm07 phm07 deleted the refactor-acc-tests branch January 9, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants