-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor acceptance test names #1069
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage 30.60% 30.60%
=======================================
Files 66 66
Lines 9942 9942
=======================================
Hits 3043 3043
Misses 6859 6859
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from the data source naming convention.
The _Basic
suffix seem unneeded, I added a bunch of examples to illustrate my idea.
6b91966
to
b62dba7
Compare
Added a missing update and rebased onto the main branch. CI is probably going to fail, feel free to merge anyway, its unrelated. |
This PR renames the acceptance test names to have a consistent schema.
Most importantly, all acceptance tests now start with
TestAcc
, making them be runnable separately from regular unit tests by specifying a regex ingo test
.