Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix subnetwork name in load balancer config #1055

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

maxnrb
Copy link
Contributor

@maxnrb maxnrb commented Nov 30, 2024

Hi, I think there's an error in the documentation

@maxnrb maxnrb requested a review from a team as a code owner November 30, 2024 04:01
@jooola
Copy link
Member

jooola commented Dec 9, 2024

Hey 👋

Thanks for the fix, but this is updating auto generated files.

Could you please fix this line https://github.com/hetznercloud/terraform-provider-hcloud/blob/main/examples/resources/hcloud_load_balancer_network/resource.tf#L29 and run make generate ?

@maxnrb
Copy link
Contributor Author

maxnrb commented Dec 12, 2024

Hi, I've just pushed the changes.

Have a nice evening.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.60%. Comparing base (cffad66) to head (25104bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1055       +/-   ##
===========================================
- Coverage   66.52%   30.60%   -35.92%     
===========================================
  Files          66       66               
  Lines        9942     9942               
===========================================
- Hits         6614     3043     -3571     
- Misses       2613     6859     +4246     
+ Partials      715       40      -675     
Flag Coverage Δ
e2e ?
unit 30.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member

jooola commented Dec 13, 2024

Ignore the failing CI, it is unrelated!

@jooola jooola merged commit 93c5f9d into hetznercloud:main Dec 13, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants