Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update primary ip arguments requirements #1017

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

ghostdevv
Copy link
Contributor

No description provided.

@ghostdevv ghostdevv requested a review from a team as a code owner October 25, 2024 03:40
@jooola jooola changed the title docs: add note on primary ip about arg requirements docs: update primary ip arguments requirements Oct 25, 2024
@jooola
Copy link
Member

jooola commented Oct 25, 2024

Thanks for the fix, I took the liberty to further improve the docs.

@jooola jooola force-pushed the update-primary-ip-docs branch from faaccea to ef03ecf Compare October 25, 2024 07:29
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.00%. Comparing base (d97adbe) to head (ef03ecf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   30.00%   30.00%           
=======================================
  Files          65       65           
  Lines        9706     9706           
=======================================
  Hits         2912     2912           
  Misses       6753     6753           
  Partials       41       41           
Flag Coverage Δ
unit 30.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 0539b84 into hetznercloud:main Oct 25, 2024
2 of 6 checks passed
@ghostdevv ghostdevv deleted the update-primary-ip-docs branch October 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants