Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix labels arguments and attributes for volumes and primary ips #1016

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Oct 22, 2024

The labels documentation was either missing or incorrect in some places for the primary ips and the volumes.

Closes #1013

@jooola jooola requested a review from a team as a code owner October 22, 2024 07:54
@jooola jooola requested a review from apricote October 22, 2024 07:54
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.75%. Comparing base (15564e1) to head (46f3af4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1016   +/-   ##
=======================================
  Coverage   65.75%   65.75%           
=======================================
  Files          65       65           
  Lines        9702     9702           
=======================================
  Hits         6380     6380           
  Misses       2619     2619           
  Partials      703      703           
Flag Coverage Δ
e2e 65.75% <ø> (ø)
unit 30.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 8f34320 into main Oct 22, 2024
7 checks passed
@jooola jooola deleted the fix-docs-labels branch October 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: hcloud_volume does not allow labels as argument
2 participants