Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use ci job matrix and fix acceptance tests #97

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Nov 1, 2023

  • Refactor the Github workflow and use a job matrix
  • Split unit tests and acceptance tests
  • Do not skip acceptance test when they are run
  • Print acceptance test log files, this ensures we always see the logs even in the CI, with no additional code.
  • Setup tps-action to provide a HCLOUD_TOKEN
  • Ensure packer-plugin-hcloud binary has a .exe on windows acceptance tests, or the binary will be ignored
  • Use the working directory as packer plugin path, this bypass the additional logic of setting up a new directory ~/.config/packer/plugins directory, which increases complexity in a cross-platform context. Note that ~ is not always expanded in the Windows CI jobs, it depends on the context where the tilde is executed.
  • Ensure we always use the bash shell in the cross-platform CI jobs.

@jooola jooola changed the title ci: refactor tests using job matrix and e2e tests ci: refactor tests using a matrix and fix acceptance tests Nov 1, 2023
@jooola jooola force-pushed the setup-e2e-tests branch 2 times, most recently from f1aa366 to ceb4903 Compare November 2, 2023 11:12
@jooola jooola requested a review from a team as a code owner November 2, 2023 11:12
@jooola jooola changed the title ci: refactor tests using a matrix and fix acceptance tests test: refactor ci tests using a matrix and fix acceptance tests Nov 2, 2023
@jooola jooola changed the title test: refactor ci tests using a matrix and fix acceptance tests test: use ci job matrix and fix acceptance tests Nov 2, 2023
@jooola jooola force-pushed the setup-e2e-tests branch 2 times, most recently from e607668 to 58ca513 Compare November 2, 2023 13:05
@jooola jooola force-pushed the setup-e2e-tests branch 2 times, most recently from fd700a4 to 8ffb7d8 Compare November 2, 2023 15:48
@jooola jooola merged commit a32e5b6 into main Nov 3, 2023
11 checks passed
@jooola jooola deleted the setup-e2e-tests branch November 3, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants