feat: add labels options to server and ssh key #92
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
is this something that has a chance to get merged? If so, I will continue working on it and include unit tests |
There was a problem hiding this comment.
@janiskemper this is off to a good start and will get merged in when ready and the CLA has been signed. I left a small suggestion but otherwise this is looking good already. Thanks!
|
Hi @janiskemper just a heads up in the next few days we will start the process of transferring this repo out of HashiCorp to the integrations team at Hetzner Cloud. Your PR will get transferred along with the repo if not merged before then. This message is meant to just inform. Please feel free to take the time you need to get this PR ready. |
|
thanks for the heads up! I am already in contact with the Hetzner team that warned me after they saw I created this PR! |
janiskemper
force-pushed
the
server-sshkey-labels
branch
from
8e3d6a6 to
f7fe515
Compare
Adding labels to the temporary server and ssh key objects which are needed to create the snapshot. This is needed in some use cases where e.g. packer build stops unexpectedly due to a SIGKILL and cannot shut down properly. In order to realize that the respective server and ssh key are orphaned, labels are needed. Signed-off-by: janiskemper <[email protected]>
janiskemper
force-pushed
the
server-sshkey-labels
branch
from
f7fe515 to
3f0a261
Compare
jooola
changed the title
| SSHKeys []string `mapstructure:"ssh_keys"` | ||
| SSHKeyLabels map[string]string `mapstructure:"sshkey_labels"` |
There was a problem hiding this comment.
Could you make the field consistent with the exiting ssh_keys field and apply the change to the rest of the PR?
| SSHKeys []string `mapstructure:"ssh_keys"` | |
| SSHKeyLabels map[string]string `mapstructure:"sshkey_labels"` | |
| SSHKeys []string `mapstructure:"ssh_keys"` | |
| SSHKeysLabels map[string]string `mapstructure:"ssh_keys_labels"` |
|
Closing in favor of #128 |
Continuation of #92 Adding labels to the temporary server and ssh key objects which are needed to create the snapshot. This is needed in some use cases where e.g. packer build stops unexpectedly due to a SIGKILL and cannot shut down properly. In order to realize that the respective server and ssh key are orphaned, labels are needed. --------- Signed-off-by: janiskemper <[email protected]> Co-authored-by: janiskemper <[email protected]>
Adding labels to the temporary server and ssh key objects which are needed to create the snapshot.
This is needed in some use cases where e.g. packer build stops unexpectedly due to a SIGKILL and cannot shut down properly. In order to realize that the respective server and ssh key are orphaned, labels are needed.