Add networks in config to allow attaching server to private net #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lbajolet-hashicorp
force-pushed
the
add-net
branch
from
39be005 to
82e6bc1
Compare
lbajolet-hashicorp
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Hi @magec,
First off apologies for taking this long to review this PR, we were busy working on other parts of Packer and its plugins.
I have read the code you submitted, and it looks good to me, I took the liberty of rebasing it on top of the current main, adapting the types and imports to use v2 of the SDK.
With this, I'll wait until tests go green, and once it does, I'll be able to merge this.
In case you want to take a look at the code before that happens, I'll postpone the merge for tomorrow.
Thanks for contributing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow attaching the server to a private network
This change allows using a private network when creating the image.
I also added a new test file to check that the this parameter is correctly being set in the http request.