Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve logs messages and error handling #139

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix: improve logs messages and error handling #139

merged 2 commits into from
Jan 3, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Jan 3, 2024

  • Refactor the error handling using a helper function.
  • Improve the logs messages and error messages.

@jooola jooola requested a review from a team as a code owner January 3, 2024 11:39
@phm07 phm07 self-requested a review January 3, 2024 12:04
@jooola jooola merged commit 2f2bcf1 into main Jan 3, 2024
10 checks passed
@jooola jooola deleted the refactor-error-handling branch January 3, 2024 12:12
@hcloud-bot hcloud-bot mentioned this pull request Jan 3, 2024
Merged
jooola added a commit that referenced this pull request Jan 3, 2024
@jooola
refactor: fix variable name
80566d0 
Related to #139
@jooola jooola mentioned this pull request Jan 3, 2024
Merged
jooola added a commit that referenced this pull request Jan 4, 2024
@jooola
refactor: fix variable name (#142)
1b957b2 
Related to #139
jooola pushed a commit that referenced this pull request Jan 12, 2024
@hcloud-bot
chore(main): release 1.3.0 (#137)
06c9b48 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](v1.2.1...v1.3.0)
(2024-01-09)


### Features

* add labels options to server and ssh keys
([#128](#128))
([3f7dcae](3f7dcae))
* use existing IP for server create
([#144](#144))
([1ebdfe7](1ebdfe7))


### Bug Fixes

* do not pass nil error to error handler
([#145](#145))
([e742263](e742263))
* improve logs messages and error handling
([#139](#139))
([2f2bcf1](2f2bcf1))
* improve missing hcloud token error
([#138](#138))
([e47f476](e47f476))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phm07 phm07 phm07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooola @phm07