-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): failed to install dependencies in StackBlitz #4639
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request involves updates to dependency versions in two files: Changes
Assessment against linked issues
The changes directly address the StackBlitz failures reported in issue #4617 by modifying the dependencies handling in the 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure might be due to the absence of a package-lock.json
.
Wouldn't providing the package-lock.json
be enough to resolve the issue?
@ryo-manba you may compare those 2 stackblitz projects from code tab and previous tab. The one from Preview tab works fine even without lock file. Don't know why there are two different implementations tho, may need to check with winches. This PR is more like hot fix so that users can see the stackblitz project from Code tab. |
Oh, I misunderstood. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's apply this as a temporary fix for now.
Eventually, it would be better to unify it.
Closes #4617
📝 Description
This PR is to
react-dom/client
from package.json⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
autoprefixer
,postcss
, andtailwindcss
in development dependenciesThese updates reflect package version improvements and refined dependency management in the project.