Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fir updates #78

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Fir updates #78

merged 4 commits into from
Dec 10, 2024

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Dec 7, 2024

@schneems schneems requested a review from a team as a code owner December 7, 2024 18:19
@heroku heroku bot temporarily deployed to getting-star-schneems-f-ilngdn December 7, 2024 18:19 Inactive
@heroku heroku bot temporarily deployed to getting-star-schneems-f-ilngdn December 7, 2024 18:30 Inactive
@schneems
Copy link
Contributor Author

schneems commented Dec 8, 2024 •
edited
Loading

Tests are failing, but looks like they have been since 2021

image

@edmorley
Copy link
Member

edmorley commented Dec 8, 2024 •
edited
Loading

Tests are failing, but looks like they have been since 2021

Yeah unfortunately PHP doesn't have working tests for its getting started guide at the moment (unlike the other languages):
#53

...which is causing Heroku CI to fail.

@edmorley edmorley merged commit 35953fe into main Dec 10, 2024
1 check failed
@edmorley edmorley deleted the schneems/fir-updates branch December 10, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneems @edmorley