Migrate to libherokubuildpack inventory #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
reviewed
Sep 25, 2024
runesoerensen
force-pushed
the
migrate-to-libherokubuildpack-inventory
branch
2 times, most recently
from
1728032
to
5b47a07
Compare
runesoerensen
requested review from
colincasey
and removed request for
a team
colincasey
approved these changes
Oct 22, 2024
This prepares the code for the migration to the `libherokubuildpack` inventory implementation which, unlike the `buildpacks-go` implementation, does not implement `Hash`
The `libherokubuildpack` implementation doesn't implement Display
This handles the toml::to_string formatting (but also introduces a risk of panics if the serialization fails
runesoerensen
force-pushed
the
migrate-to-libherokubuildpack-inventory
branch
from
5b47a07
to
5a2c3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
heroku-inventory-utilsdependency in favor of the recently migratedinventorycode inlibherokubuildpack.