-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use a matrix for test configurations #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! The CI times look very promising. :)
I added some comments.
Also, I'd like the cache to be restricted to main before merging this.
Nit: I think we can remove the parentheses from most literals.
After configuring with a single matrix, I think it may make more sense to create a basis action for the setup and use it with two separate matrices for the networked and not networked jobs. |
I think the cache change works because the last cache item from this pull request on the list was added right before the commit that disabled caching. I normally wouldn't mix the two changes as they are not really related but I forgot that I was on the branch with the cache change. |
I'd rather not split the setup into different files. Having all this together makes it straightforward to understand for newcomers. How about removing the
Looks good! 👍
Feel free to wildly rebase and force-push on PRs. You could also extract that into another PR, so we can merge that already. :) PS: You can re-request a review from me in the top right, when you want me to review again. |
I tried that but the configurations added via I opened a separate PR for the cache issue. After it is merged I will rebase this one on it and request a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Only one more nit. Thereafter, I'll merge this. 👍
A shorter job name will allow configuration matrix variables to be visible in the overview Co-authored-by: Martin Kröning <[email protected]>
Makes a lot of sense, I had to resize the left pane via inspect element during testing 😂 |
Use a test configuration matrix to increase architecture testing parity, decrease CI configuration duplication and run tests at parallel, at the cost of increased compute and storage usage.