-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity-mapped pagetable support (UEFI boot) #924
Conversation
902379a
to
8eb79fd
Compare
8eb79fd
to
141bd32
Compare
src/arch/x86_64/kernel/mod.rs
Outdated
boot_info().hardware_info.phys_addr_range.start as usize | ||
} | ||
|
||
pub fn is_uefi() -> Result<(), ()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you don't just return a bool?
- reserved_space) | ||
.align_down(LargePageSize::SIZE as usize) | ||
}; | ||
// if !crate::arch::x86_64::kernel::is_uefi() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be removed 🙂
src/arch/x86_64/mm/paging.rs
Outdated
@@ -64,6 +70,16 @@ unsafe fn recursive_page_table() -> RecursivePageTable<'static> { | |||
} | |||
} | |||
|
|||
unsafe fn identity_mapped_page_table() -> OffsetPageTable<'static> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate a short doc comment, as I think it is not 100% obvious what the function is doing.
Signed-off-by: Martin Kröning <[email protected]>
…t page writable Signed-off-by: Martin Kröning <[email protected]>
… available) + minor inconsistency fixes (e.g., Size4KiB and BasePageSize being used simultaneously)
…tside of forbidden range
…tions accordingly
…apted to that as well
…ADT) and parse the Fixed ACPI Description Table (FADT) (parsing in itself is successful but it still breaks because of a deallocate)
…s (currently only one core supported)
…s (currently only one core supported)
4c235e5
to
c444c99
Compare
…g for UEFI ACPI tables since that's already given
OG: 9b8db51