Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid unnecessary dereference in futex_wake #1521

Merged
merged 1 commit into from
Dec 18, 2024
Merged

avoid unnecessary dereference in futex_wake #1521

merged 1 commit into from
Dec 18, 2024

Conversation

m-mueller678
Copy link
Contributor

In the futex_wake syscall, the address of the passed pointer is used to index a hash map. This pull request removes an unnecessary roundtrip through &AtomicU32 and thereby make it safe to call futex_wake with a dangling pointer. This change enables using futex_wake in parking_lot_core without additional locking.

@mkroening mkroening self-assigned this Dec 17, 2024
mkroening
mkroening approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkroening mkroening added this pull request to the merge queue Dec 18, 2024
Merged via the queue into hermit-os:main with commit be6c4dd Dec 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroening mkroening mkroening approved these changes

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-mueller678 @mkroening