Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build kernel directly instead of via hermit-playground #39

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: build kernel directly instead of via hermit-playground #39

merged 1 commit into from
Aug 13, 2024

Conversation

mkroening
Copy link
Member

No description provided.

@mkroening mkroening self-assigned this Aug 13, 2024
@mkroening mkroening marked this pull request as ready for review August 13, 2024 09:31
@mkroening mkroening requested a review from CarlWachter August 13, 2024 09:32
@mkroening mkroening mentioned this pull request Aug 13, 2024
Closed
@CarlWachter
Copy link
Contributor

I think it's a great idea to build the kernel directly, but i think it should be built from the librs submodule of hermit-playground, rather than the latest kernel, to ensure that compatibility does not break.

@mkroening
Copy link
Member Author

mkroening commented Aug 13, 2024 •
edited
Loading

My goal is to eventually remove the bundled libhermit.a and kernel headers from the toolchain and have users build and supply their own libhermit.a. I'd also like to introduce C tests into the kernel repo to ensure, the kernel repo is always good for C apps. Would merging this PR with these plans be all right with you?

CarlWachter
CarlWachter approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@CarlWachter CarlWachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sounds like a good plan

@mkroening mkroening added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit e1bbe99 Aug 13, 2024
1 check passed
@mkroening mkroening mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlWachter CarlWachter CarlWachter approved these changes

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkroening @CarlWachter