Skip to content

Commit

Permalink
Explicitly specify char signedness for the underlying enum type (face…
Browse files Browse the repository at this point in the history
…book#1313)

Summary:
A plain 'char' without 'signed' or 'unsigned' may default to either one, depending on the platform. On x86_64 Linux it is signed, while on ARM Linux it is unsigned, resulting in a build error. Fix by explicitly marking it signed.

Squash with 295ba21

Pull Request resolved: facebook#1313

Differential Revision: D46285396
  • Loading branch information
laurynas-biveinis authored and Herman Lee committed Oct 3, 2023
1 parent d82966d commit 982d814
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion client/mysqlbinlog.cc
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ static const std::string binlog_server_finish_err_msg =
"The binlog server has finished sending all available binlogs from the "
"HDFS and has no more binlogs to send.";

enum class Check_database_decision : char {
enum class Check_database_decision {
EMPTY_EVENT_DATABASE = 2,
CHANGED = 1,
OK = 0,
Expand Down

0 comments on commit 982d814

Please sign in to comment.