Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
129390: workflows: disable cockroach-microbench-ci step for pull requests r=sambhav-jain-16 a=sambhav-jain-16

This change disbales the CI step for pull requests but this still runs for push step into the target branch. Also the count of the microbenchmarks are increased to get more robust results.

Epic: none

Release note: None

Co-authored-by: Sambhav Jain <[email protected]>
  • Loading branch information
craig[bot] and sambhav-jain-16 committed Aug 27, 2024
2 parents 6866fbf + e2b7b6c commit 79f7121
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/github-actions-essential-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,8 @@ jobs:
if: always()
cockroach-microbench-ci:
runs-on: [ self-hosted, basic_runner_group ]
# TODO(sambhav-jain-16): enable this for pull requests also
if: ${{ github.event_name == 'push' }}
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion build/github/cockroach-microbench-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ bazel test //pkg/sql/tests:tests_test \
--test_sharding_strategy=disabled \
--test_arg=-test.cpu --test_arg=1 \
--test_arg=-test.v \
--test_arg=-test.count=4 \
--test_arg=-test.count=10 \
--test_arg=-test.benchmem \
--crdb_test_off \
--test_output=all > "$log_output_file_path"
Expand Down

0 comments on commit 79f7121

Please sign in to comment.