Merge cockroachdb#113230

113230: build: fix test name and visibility in schema change test script r=rafiss a=rafiss The previous commit (3d36139) forgot to update the name of the test in the script when it was renamed, and also forgot to update the bazel visibility rules. Epic: None Release note: None Co-authored-by: Rafi Shamim <[email protected]>
herkolategan · Oct 31, 2023 · 71aaf66 · 71aaf66
2 parents 150820e + ea61823
commit 71aaf66
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 441 deletions.
diff --git a/build/teamcity/cockroach/nightlies/schema_changer_comparator_nightly_impl.sh b/build/teamcity/cockroach/nightlies/schema_changer_comparator_nightly_impl.sh
@@ -14,7 +14,7 @@ BAZEL_BIN=$(bazel info bazel-bin --config=ci)
 # Run schema changer comparator test.
 $BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci test -- --config=ci \
   //pkg/sql/schemachanger:schemachanger_test \
-  --test_filter='^TestComparatorFromLogicTests' \
+  --test_filter='^TestSchemaChangeComparator' \
   --test_env=GO_TEST_WRAP_TESTV=1 \
   --test_env=GO_TEST_WRAP=1 \
   --test_env=COCKROACH_SCHEMA_CHANGE_COMPARATOR_SKIP=false \

diff --git a/pkg/sql/schemachanger/BUILD.bazel b/pkg/sql/schemachanger/BUILD.bazel
@@ -24,6 +24,7 @@ go_test(
     name = "schemachanger_test",
     size = "enormous",
     srcs = [
+        "comparator_generated_test.go",  # keep
         "comparator_test.go",
         "dml_injection_test.go",
         "main_test.go",
@@ -34,7 +35,9 @@ go_test(
         "//build/toolchains:use_ci_timeouts": ["-test.timeout=895s"],
         "//conditions:default": ["-test.timeout=3595s"],
     }),
-    data = glob(["testdata/**"]),
+    data = glob(["testdata/**"]) + [
+        "//pkg/sql/logictest:testdata",
+    ],
     exec_properties = {"Pool": "large"},
     shard_count = 16,
     deps = [