Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-aym branch #1

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

dev-aym branch #1

wants to merge 17 commits into from

Conversation

aymgal
Copy link

@aymgal aymgal commented Nov 13, 2019

That's the current status of my fork, mostly with fixes for Pyhon 3.

Below are some questions about the code.

@aymgal
Copy link
Author

aymgal commented Nov 13, 2019

  • This line in Solve.SLIT(...) (also in SLIT_MCA(...)), why is the argument PSFconj overwritten here ?

    PSFconj = PSF.T

  • Can you explain in more details the behaviour of this soft thresholding operator Soft(...) ? it seems to do special things at specific starlet scales ?

    def Soft(X, level, k, supp =1, Kill = 0):

@aymgal
Copy link
Author

aymgal commented Nov 19, 2019

Thanks 😉
Extra question : why do you normalise by onelens here ?

return Image/onelens

@herjy
Copy link
Owner

herjy commented Nov 19, 2019

To answer your questions in order:

  • PSFconj should be removed from the arguments list.
  • In soft thresholding, I raise the threshold by 1 in the first scale. That's more of a familly recipe, but you will notice that in astronomical images, you will want to cut extra power in the high frequencies.
  • If I recal, this is used to compute the noise levels only. onelens will be set to 1 in all other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants