Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runNixDarwin: add -H to sudo #184

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 20, 2025

Motivation

fixes this warning:

warning: $HOME ('/Users/customer') is not owned by you, falling back to the one defined in the 'passwd' file ('/var/root')

matches the sudo command used in nix-darwin:

https://github.com/LnL7/nix-darwin/blob/87131f51f8256952d1a306b5521cedc2dc61aa08/pkgs/nix-tools/darwin-rebuild.sh#L27

Maintainer checklist

  • Documentation (function reference docs, setup guide, option reference docs)
  • Has tests (VM test, free account, and/or test instructions)
  • Is the corresponding module up to date?

fixes this warning:

warning: $HOME ('/Users/customer') is not owned by you,
falling back to the one defined in the 'passwd' file ('/var/root')

matches the sudo command used in nix-darwin:

https://github.com/LnL7/nix-darwin/blob/87131f51f8256952d1a306b5521cedc2dc61aa08/pkgs/nix-tools/darwin-rebuild.sh#L27
@zowoq zowoq requested a review from roberth as a code owner January 20, 2025 04:07
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zowoq
Copy link
Contributor Author

zowoq commented Jan 30, 2025

@roberth Is this PR okay to merge?

@roberth roberth merged commit 6d1b6d5 into hercules-ci:master Jan 30, 2025
3 checks passed
@roberth
Copy link
Member

roberth commented Jan 30, 2025

Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants