Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flake): allow defaultPackage to evaluate #240

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

tomeon
Copy link
Contributor

@tomeon tomeon commented Apr 28, 2024

by adding the missing (and in this case ignored) key/attribute-name argument to lib.mapAttrs.

Without this, trying to evaluate defaultPackage triggers the error error: value is a string while a set was expected.

Discovered in running nix flake check while working on #92.

Thanks!

by adding the missing (and in this case ignored) key/attribute-name
argument to `lib.mapAttrs`.
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a deprecated attribute, but thanks anyway!

@roberth roberth enabled auto-merge April 28, 2024 18:22
@roberth roberth merged commit efa008e into hercules-ci:main Apr 28, 2024
3 checks passed
@tomeon
Copy link
Contributor Author

tomeon commented Apr 28, 2024

Thanks for merging this!

It's a deprecated attribute

Indeed -- kinda hard to miss given the warning message in its definition 😉 -- though I think a fuller and more salient description would be "meant-to-be-deprecated attribute whose definition broke the ability to run nix flake check". I'd be happy to tackle removing defaultPackage altogether if it would be appropriate at this point, and I suspect it probably is appropriate (or at least safe) given that defaultPackage was unusable up until you merged my changes, and nobody before me seems to have noticed.

@roberth
Copy link
Member

roberth commented Apr 28, 2024

Oh, yeah, it does warn about that. It's also been deprecated for a long time now. Feel free to remove it 👍

tomeon added a commit to tomeon/arion that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants