Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the eclass-reading code #981

Closed
wants to merge 4 commits into from
Closed

Conversation

pavpanchekha
Copy link
Contributor

This PR basically attempts to optimize split-untyped-eclasses, which on its own is about 7.5 minutes of runtime in a nightly. To do so it:

  • Uses sequences of "stream in" enodes instead of ever allocating a vector of all the ones in an eclass. This also reduces allocations.
  • Micro-optimizes the transformations from types and egg eclass ids to Herbie-side ids
  • Unpacks enodes in a couple of cases to save a minute number of allocations

The results code is fairly ugly (it is almost C code) and it's not clear if the result is actually much faster. Life is hard!

@pavpanchekha
Copy link
Contributor Author

Not faster (slower)

@pavpanchekha pavpanchekha deleted the egraph-enode-rewrite branch September 26, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant