Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1058 #1071

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix for issue 1058 #1071

wants to merge 1 commit into from

Conversation

zaneenders
Copy link
Collaborator

This PR is working on #1058.

⚠️ I gotta hit pause on this for a few days. But I have a hunch this might be a bit more complicated as I don't know if Odyssey supports Preprocessing right now.

If you look at the Diff the the /alternatives route ignores preprocessing right now. I have some hacks and copied code to try and get this to work but running into the following error from the proceeding mathjs call..

Converting to Math.js #<syntax:web::1 "x_m = (fabs.f64 x)\n(FPCore (x_m) :precision binary64 x_m)">...Error handling request: match: no matching clause for "x_m = (fabs.f64 x)\n(FPCore (x_m) :precision binary64 x_m)"
  location...:
   src/reports/core2mathjs.rkt:155:6
  context...:
   /Users/zane/.scribe/Projects/herbie/src/reports/core2mathjs.rkt:149:0: core->mathjs
   /Users/zane/.scribe/Projects/herbie/src/api/demo.rkt:511:27
   /Users/zane/.scribe/Projects/herbie/src/api/demo.rkt:240:2
   /opt/homebrew/Cellar/minimal-racket/8.15/share/racket/collects/racket/contract/private/arrow-higher-order.rkt:375:33
   [repeats 1 more time]
   /opt/homebrew/opt/minimal-racket/share/racket/pkgs/web-server-lib/web-server/dispatchers/dispatch-servlets.rkt:63:2
   /opt/homebrew/opt/minimal-racket/share/racket/pkgs/web-server-lib/web-server/private/dispatch-server-with-connect-unit.rkt:141:2

I'm not sure where and what the fix should be yet but I know what the problem is.

Below is the correct view on the demo the Edward pointed out in the issue.

Screenshot 2024-11-21 at 6 44 34 PM

@zaneenders zaneenders changed the title Gotta hit pause for now. Fix for issue 1058 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant