Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet connect CSP configuration #793

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented Jan 27, 2025

Description

Staging (and prod) are showing the following errors

image

It seems after we updated Wagmi and viem, new URLs were added for connecting to WalletConnect. This is regardless of the secrets for Wallet Connect being enabled or not (which they're not yet).

This PR generalizes the domain URLs for WalletConnect so they are allowed in CSP. I couldn't find any https://*.walletconnect.com request, so I did not add it

Screenshots

Related issue(s)

Related to #633

Checklist

  • Manual testing passed.
  • Automated tests added, or N/A.
  • Documentation updated, or N/A.
  • Environment variables set in CI, or N/A.

Copy link
Contributor

@ArturDolzan ArturDolzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uACK

@gndelia gndelia merged commit 763eee2 into main Jan 28, 2025
6 checks passed
@gndelia gndelia deleted the add-csp-wallet-connect branch January 28, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants