Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI setup #8

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Improve CI setup #8

merged 3 commits into from
Oct 31, 2024

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented Oct 30, 2024

This PR improves the CI setup to match the ones set across our different repos.

  • NPM badge added to README
  • Prettier
  • Commitlint
  • Checking of package.json order

Copy link

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions but can go in as is if everyone else is okay with it (so I'm approving to not block things).

.github/workflows/js-checks.yml Show resolved Hide resolved
.husky/commit-msg Show resolved Hide resolved
.husky/pre-commit Show resolved Hide resolved
.nvmrc Show resolved Hide resolved
@gndelia gndelia requested a review from mbonfoster October 31, 2024 13:59
@gndelia gndelia merged commit ff941b8 into master Oct 31, 2024
10 checks passed
@gndelia gndelia deleted the repo-improvements branch October 31, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants