Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor errors to improve overall consistency #80

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

joshuasing
Copy link
Contributor

@joshuasing joshuasing commented Apr 16, 2024

Summary
Refactor errors to help improve overall consistency.

Related: #27, #32

Changes

@joshuasing joshuasing added the type: refactor This refactors existing functionality label Apr 16, 2024
Copy link
Contributor

@marcopeereboom marcopeereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMGYES

Copy link
Contributor

@ClaytonNorthey92 ClaytonNorthey92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass, I vote merge ✅

@joshuasing joshuasing merged commit 6b31bcc into main Apr 18, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/slightly-more-consistent-errors branch April 18, 2024 14:16
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor This refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants