in tbc tests, terminate containers after test finishes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
joshuasing
reviewed
Apr 15, 2024
joshuasing
approved these changes
Apr 15, 2024
|
let's hold off on merging; the pipeline is failing, I think this is exposing an issue in the tests |
containers were not terminating after a test had finished, they were hanging around until the tests were done running; it seems that canceling a context does not termiante a container terminate container in each test, pushing to the defer stack
ClaytonNorthey92
force-pushed
the
clayton/terminate-containers
branch
from
9386a82 to
400d9ba
Compare
|
closing, addressed in this commit d1d9e30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
containers were not terminating after a test had finished, they were hanging around until the tests were done running; it seems that canceling a context does not termiante a container>
Changes
terminate container in each test, pushing to the defer stack
note: I do not update
network_test.gobecause that doesn't create many containers, and it is likely to go away with localnetfixes #62